Skip to content

chore: Enable auto-merge for dependabot PRs #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2021

Conversation

dreamorosi
Copy link
Contributor

@dreamorosi dreamorosi commented Aug 11, 2021

Description of your changes

Following the discussion in issue #126 and on Slack I have added a new workflow called Dependabot PR auto-merge - auto-merge.yml.

that should run when these conditions happen:

  • on-pull-request workflow runs and completes successfully. This means that all the checks around linting, unit tests, and code coverage have passed.
  • The actor of the PR was dependabot.

At this point the workflow identifies and downloads locally the PR artifact, after which adds a review and merges the PR.

The idea behind this workflow is to automate repetitive & undifferentiated work for maintainers. The definition of the workflow is heavily inspired by the one used in the Java version of Powertools.

NOTE: This workflow relies on the existence of a repository secret called AUTOMERGE_DEPENDABOT that will need to be added if this PR gets merged. Changed in 88c2046

More info on this here.

How to verify this change

When dependabot opens the next PR, if the on-pull-request checks are successful, this new workflow should run and merge the PR automatically.

Related issues, RFCs

#126

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published in downstream module
  • The PR title follows the conventional commit semantics

Breaking change checklist

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dreamorosi dreamorosi added this to the beta-release milestone Aug 11, 2021
@dreamorosi dreamorosi self-assigned this Aug 11, 2021
@github-actions
Copy link
Contributor

Coverage after merging ci/dependabot_automation into main

100.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
./packages/logger/src
   Logger.ts100%100%100%100%
   helpers.ts100%100%100%100%
   index.ts100%100%100%100%
./packages/logger/src/config
   ConfigService.ts100%100%100%100%
   EnvironmentVariablesService.ts100%100%100%100%
   index.ts100%100%100%100%
./packages/logger/src/formatter
   LogFormatter.ts100%100%100%100%
   PowertoolLogFormatter.ts100%100%100%100%
   index.ts100%100%100%100%
./packages/logger/src/log
   LogItem.ts100%100%100%100%
   index.ts100%100%100%100%
./packages/metrics/src
   Metrics.ts100%100%100%100%
   index.ts100%100%100%100%
./packages/metrics/src/config
   ConfigService.ts100%100%100%100%
   EnvironmentVariablesService.ts100%100%100%100%
   index.ts100%100%100%100%

@dreamorosi dreamorosi added the automation This item relates to automation label Aug 11, 2021
@github-actions
Copy link
Contributor

Coverage after merging ci/dependabot_automation into main

100.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
./packages/logger/src
   Logger.ts100%100%100%100%
   helpers.ts100%100%100%100%
   index.ts100%100%100%100%
./packages/logger/src/config
   ConfigService.ts100%100%100%100%
   EnvironmentVariablesService.ts100%100%100%100%
   index.ts100%100%100%100%
./packages/logger/src/formatter
   LogFormatter.ts100%100%100%100%
   PowertoolLogFormatter.ts100%100%100%100%
   index.ts100%100%100%100%
./packages/logger/src/log
   LogItem.ts100%100%100%100%
   index.ts100%100%100%100%
./packages/metrics/src
   Metrics.ts100%100%100%100%
   index.ts100%100%100%100%
./packages/metrics/src/config
   ConfigService.ts100%100%100%100%
   EnvironmentVariablesService.ts100%100%100%100%
   index.ts100%100%100%100%

@dreamorosi dreamorosi requested a review from bahrmichael August 12, 2021 14:24
@dreamorosi dreamorosi merged commit 922d309 into main Aug 13, 2021
@dreamorosi dreamorosi deleted the ci/dependabot_automation branch August 13, 2021 10:20
@heitorlessa heitorlessa added the internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) label Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants